Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojure BERT finetuning example: fix CSV parsing #5

Conversation

daveliepmann
Copy link

Description

Fixes CSV parsing issues raised in my PR comment. Specifically, this PR modifies the Jupyter notebook to:

  • strip quotation marks from the parsed CSV file, preventing the accidental merging of separate examples
  • use strict CSV parsing to surface any similar problems in the future
  • remove an unused epoch def

I think this works OK for all examples. It's possible that not having quotation marks negatively affects correct performance, but if so, it would be less so than mixing up examples with each other.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@gigasquid
Copy link
Owner

Thanks so much @daveliepmann !

@gigasquid gigasquid merged commit bb37715 into gigasquid:new-bert-example-with-finetuning May 1, 2019
@daveliepmann daveliepmann deleted the new-bert-example-with-finetuning-csv-fix branch May 1, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants