-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add info about payrun close action #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add info about payrun close action #14
Conversation
source/includes/_invoices.md
Outdated
|
|
||
| In a general setup, invoices get created in an open state (pro-forma) without being finalized and thus enforced as invoices. This is to allow users to edit their invoices before they feel lik submitting it. | ||
| Once the editing phace of the pro-forma is done, we convert it to an invoice by finalizing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phace to phase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use AI for better wording.
In a general setup, invoices get created in an open state (pro-forma) without being finalized and thus enforced as invoices. This is to allow users to edit their invoices before they feel lik submitting it.
and
Once the editing phace of the pro-forma is done, we convert it to an invoice by finalizing it.
These two lines sounds describing same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the text now
source/includes/_invoices.md
Outdated
| > The above command returns an empty response. | ||
|
|
||
| In a general setup, invoices are initially created in an open state (pro-forma) and are not immediately finalized. This allows users to review and edit their invoices before submission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a general setup? what other setups are there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can have that invoices autoclose when created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding this information might help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is shared outside of the api docs. Maybe we can include it in the future through
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This In a general setup looks confusing to me, as there is no information in this api documentation about what a general setup is. Maybe remove this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Adds documentation for the /close endpoint in the v2/invoices