Skip to content

Conversation

@EmberCraze
Copy link

@EmberCraze EmberCraze commented May 13, 2025

Adds documentation for the /close endpoint in the v2/invoices


In a general setup, invoices get created in an open state (pro-forma) without being finalized and thus enforced as invoices. This is to allow users to edit their invoices before they feel lik submitting it.
Once the editing phace of the pro-forma is done, we convert it to an invoice by finalizing it.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phace to phase

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use AI for better wording.
In a general setup, invoices get created in an open state (pro-forma) without being finalized and thus enforced as invoices. This is to allow users to edit their invoices before they feel lik submitting it.
and
Once the editing phace of the pro-forma is done, we convert it to an invoice by finalizing it.
These two lines sounds describing same thing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the text now

@EmberCraze EmberCraze requested a review from mdamire May 13, 2025 11:54
> The above command returns an empty response.

In a general setup, invoices are initially created in an open state (pro-forma) and are not immediately finalized. This allows users to review and edit their invoices before submission.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's a general setup? what other setups are there?

Copy link
Author

@EmberCraze EmberCraze May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have that invoices autoclose when created.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this information might help.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shared outside of the api docs. Maybe we can include it in the future through

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This In a general setup looks confusing to me, as there is no information in this api documentation about what a general setup is. Maybe remove this part?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sounds good

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@EmberCraze EmberCraze merged commit 96fe5b4 into main May 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants