Add option for omitting custom fields #23
Conversation
lib/index.ts
Outdated
| } = options; | ||
| props = [...defaultSupportedMetaProps, ...props]; | ||
| omitted = new Set(options.omitId ? ['__v', '_id'] : ['__v']); | ||
| omitted = new Set(omitId ? ['__v', '_id'] : ['__v']); |
There was a problem hiding this comment.
is there a reason you're creating a new set instead of just adding the keys to the existing set?
There was a problem hiding this comment.
Yes.
omitted variable is in the outer scope, so if we change it, the new value will be used in next function calls.
By making a new set we drop it back to default every function call.
There was a problem hiding this comment.
ah good catch -
the omitted variable in the root scope is in use by the function removeOmitted also in the root scope.
assigning the new Set to the root level omitted variable still globally mutates the root scope.
since removeOmitted is only used once within the scope of documentModel you could just move that function declaration to be in scope of documentModel and set it once as a fn of defaults + input omitFields
mongoose-to-swagger/lib/index.ts
Line 218 in 3d06ca2
mongoose-to-swagger/lib/index.ts
Line 228 in 3d06ca2
|
published @ [email protected] |
#19