Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evol return exception #93

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Conversation

Ducarouge
Copy link

Hi and happy new year,

Thank you very much for this API witch is very useful.

We are using it in a big project for the IGN geoplatform and we need a cleaner way to catch the errors return by the API.

This PR offers a more consistent way to handle exceptions. I hope this does not impact to much the use of the API and i'm open to discussion.

It would be great if we can merge and continue to contribute to your project (and not in a fork).

@iamtekson
Copy link
Collaborator

Hi @Ducarouge, Happy New Year! and Thank you very much for your valuable contribution.

As I see, you have changed the multiple things in a same PR. It is little bit harder for me to review the full code. Let me get some time and review it soon. Thanks again for your time and contribution.

@iamtekson iamtekson merged commit 62e34f9 into gicait:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants