More request customization #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Trevor James Smith <[email protected]>
…rent python versions
|
Thank you @iboates for initiating this PR. it looks great in shape! |
|
Just FYI im on vacation until July. I might pick at this anyway in the meantime though |
|
No worried @iboates, take your time😀! |
…firm that custom request options get passed properly
|
@iamtekson @Zeitsperre I am now finished with this. You should be able to specify a dictionary of request parameters to the Originally I wanted to do it for each request, but the overwhelming DRY violations were too bothersome to ignore. I also added a few new tests while I was at it, including one specifically to test that that this works. Also, I replaced all the direct references to the requests lib with ones to the internally wrapped version. |
iboates
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #133 and #82
This is a draft PR, it's not even close to being finished. It's also contingent on my tests branch PR here: #151
I have changed all the
workspaceendpoints to accommodate it. It should work, but I am wondering if it may be better to use something likerequest_paramsinstead ofkwargs, just so as not to potentially interfere with other keyword arguments. Such a parameter would I guess have to be a type ofDict[String, Any]What do you guys think? For whichever option, I can add the functionality to the rest of the endpoints.