remove layer from layergroup #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will review it soon! give me this week. Thanks. |
iamtekson
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature?
remove_layer_from_layergroup: works analogously toadd_layer_to_layergroupand can be used to remove a single layer from an existing layergroupadd_layer_to_layergroupto avoid code duplication betweenadd_layer_to_layergroupandremove_layer_from_layergroup(separate method for xml construction is shared between the two methods)How to test?
I've added some new unittests for the new method to the existing unittest class; they can be run by executing
python -m unittest tests.test_layergroupCloses #105