CAPA: Release v29.6.0. #1550

AndiDog · 2025-01-23T11:13:48Z

Towards giantswarm/roadmap#3795, https://github.com/giantswarm/giantswarm/issues/32487, https://github.com/giantswarm/giantswarm/issues/32045

Checklist

Roadmap issue created
Release uses latest stable Flatcar
Release uses latest Kubernetes patch version

… (proxy support for private clusters)

tityosbot · 2025-01-23T11:13:51Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

AndiDog · 2025-01-23T11:14:36Z

/run releases-test-suites PROVIDER=capa

tinkerers-ci · 2025-01-23T11:14:45Z

⚠️ Trigger /run releases-test-suites PROVIDER=capa contains unknown arguments:

PROVIDER

AndiDog · 2025-01-23T11:17:08Z

/run releases-test-suites

capa/v29.6.0/release.yaml

Gacko · 2025-01-23T11:52:20Z

Is this release fixing something related to AWS Node Termination Handler? If so, please wait with releasing this. We were already about to do so or at least were talking about it. There are more things to be updated than just the AWS Node Termination Handler. Cabbage e.g. is just about to put in requests for a last Cilium patch and Shield recently requested security-bundle v1.9.1. So overall I'd be happy to have a talk about this and sync with releases for other providers.

Also I'd prefer using the new devctl approach starting with v30.

Gacko · 2025-01-23T11:56:58Z

Towards [...] https://github.com/giantswarm/giantswarm/issues/32045

This is not yet merged to main of cluster chart and even if it would, you could not use it as main of cluster contains breaking changes to be releases in v30 earliest.

tinkerers-ci · 2025-01-23T12:27:55Z

releases-test-suites

Run name	`pr-releases-1550-releases-test-suites848p9`
Commit SHA	`b820695`
Result	Succeeded ✅

📋 View full results in Tekton Dashboard

Rerun trigger:
/run releases-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run releases-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

Alternatively, or in addition to, you can also specify TARGET_RELEASES to trigger tests for specific releases. E.g. /run releases-test-suites TARGET_SUITES=./providers/capa/standard TARGET_RELEASES=aws-25.0.0-test.1

AndiDog · 2025-01-23T16:43:01Z

capa/v29.6.0/README.md

@@ -0,0 +1,88 @@
+# :zap: Giant Swarm Release v29.6.0 for CAPA :zap:
+
+<< Add description here >>


AndiDog · 2025-01-23T16:43:07Z

capa/v29.6.0/announcement.md

@@ -0,0 +1,3 @@
+**Workload cluster release v29.6.0 for CAPA is available**. << Add description here >> 


njuettner

Structure looks good to me, can't tell about the changes in general

Gacko

As stated before, I'd prefer starting to use the reworked devctl approach in v30 earliest. It changes how the diffs look like, reorders manifests and still contains some issues around the templating in general (whitespaces, inconsistency in listing version numbers (sometimes with v, some without) and others).

Also I feel like the reduction in etcd volume size should have been shipped in a major release (and should probably also not be back-ported to v1.3.x 😉).

Gacko · 2025-01-27T19:35:53Z

Same as for v28.5.0: May I suggest merging this PR on top of yours? As stated before, we'd prefer not using the new devctl approach for existing major releases and instead start using it in v30.0.0.

My suggestion therefore just reproduces what you already proposed by using the manual approach of copying and altering the previous minor release.

AndiDog · 2025-01-28T09:15:53Z

Also I feel like the reduction in etcd volume size should have been shipped in a major release

The storage quota (see cluster's quotaBackendBytesGiB = 8) limits overall usage, so even the new default is way too high. Therefore I'd consider that okay in a minor release bump that mentions the change. We could have mentioned the rationale in the commit/changelog message, maybe.

Gacko

/run releases-test-suites PREVIOUS_RELEASE=29.5.0

Gacko · 2025-01-28T10:24:53Z

Also I feel like the reduction in etcd volume size should have been shipped in a major release

The storage quota (see cluster's quotaBackendBytesGiB = 8) limits overall usage, so even the new default is way too high. Therefore I'd consider that okay in a minor release bump that mentions the change. We could have mentioned the rationale in the commit/changelog message, maybe.

You're absolutely right on that. From a Giant Swarm and technical point of view, the reduction probably doesn't hurt. But I don't know the customer / user point of view on this. So let's just hope nobody's complaining about it in the end. 😅

so even the new default is way too high

One note on that: Customers can configure the quota to 16 GB. Worst case and depending on how etcd is defragmenting / rewriting its database files and from my experience with databases, I'd expect this to consume twice the amount of the quota. So 32 GB. We can still further reduce it, but I'd not save in the wrong place.

Gacko · 2025-01-28T10:26:30Z

/run releases-test-suites PREVIOUS_RELEASE=29.5.0

AndiDog

@giantswarm/team-cabbage could you also take a look? Particularly if the Cilium bump is fine?

ubergesundheit

cilium-wise LGTM

tinkerers-ci · 2025-01-28T11:56:44Z

releases-test-suites

Run name	`pr-releases-1550-releases-test-suites585l2`
Commit SHA	`fe1225a`
Result	Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run releases-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run releases-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

Alternatively, or in addition to, you can also specify TARGET_RELEASES to trigger tests for specific releases. E.g. /run releases-test-suites TARGET_SUITES=./providers/capa/standard TARGET_RELEASES=aws-25.0.0-test.1

T-Kukawka · 2025-01-28T12:05:44Z

added release notes, please review

capa/v29.6.0/README.md

capa/v29.6.0/announcement.md

Gacko · 2025-01-28T12:20:31Z

/run releases-test-suites PREVIOUS_RELEASE=29.5.0

tinkerers-ci · 2025-01-28T13:36:18Z

releases-test-suites

Run name	`pr-releases-1550-releases-test-suites7x24r`
Commit SHA	`4e20e08`
Result	Succeeded ✅

📋 View full results in Tekton Dashboard

Rerun trigger:
/run releases-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run releases-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

Alternatively, or in addition to, you can also specify TARGET_RELEASES to trigger tests for specific releases. E.g. /run releases-test-suites TARGET_SUITES=./providers/capa/standard TARGET_RELEASES=aws-25.0.0-test.1

AndiDog added 2 commits January 23, 2025 12:10

Create CAPA v29.6.0 (no changes)

1b73148

Bump cluster-aws (reduced IAM permissions support) and aws-nth-bundle…

b820695

… (proxy support for private clusters)

AndiDog requested a review from a team January 23, 2025 11:13

AndiDog changed the title ~~Capa 29 6 0~~ CAPA: Release v29.6.0 Jan 23, 2025

AndiDog commented Jan 23, 2025

View reviewed changes

capa/v29.6.0/release.yaml Outdated Show resolved Hide resolved

Final versions of components

f1a0a5f

AndiDog marked this pull request as ready for review January 23, 2025 16:06

AndiDog requested a review from a team as a code owner January 23, 2025 16:06

AndiDog added 2 commits January 23, 2025 17:08

cilium-app wanted is v0.25.2 in latest requests

ef55ccf

Merge branch 'master' into capa-29-6-0

3be5a52

AndiDog requested review from a team January 23, 2025 16:09

stone-z approved these changes Jan 23, 2025

View reviewed changes

AndiDog commented Jan 23, 2025

View reviewed changes

Add README link

edae2fc

AndiDog mentioned this pull request Jan 23, 2025

CAPA: Release v28.5.0. #1552

Merged

3 tasks

njuettner approved these changes Jan 24, 2025

View reviewed changes

Gacko requested changes Jan 24, 2025

View reviewed changes

Merge branch 'master' into capa-29-6-0

c0c9551

Gacko changed the title ~~CAPA: Release v29.6.0~~ CAPA: Release v29.6.0. Jan 27, 2025

CAPA v29.6.0: Suggestions for improvement. (#1555)

fe1225a

Gacko approved these changes Jan 28, 2025

View reviewed changes

Gacko enabled auto-merge (squash) January 28, 2025 10:12

AndiDog commented Jan 28, 2025

View reviewed changes

ubergesundheit approved these changes Jan 28, 2025

View reviewed changes

T-Kukawka added 2 commits January 28, 2025 13:02

Update README.md

168c957

Update announcement.md

8a7d7d2

Gacko reviewed Jan 28, 2025

View reviewed changes

capa/v29.6.0/README.md Outdated Show resolved Hide resolved

capa/v29.6.0/announcement.md Outdated Show resolved Hide resolved

Fix typo

4e20e08

Gacko disabled auto-merge January 28, 2025 13:40

Gacko merged commit b38bebd into master Jan 28, 2025
6 checks passed

Gacko deleted the capa-29-6-0 branch January 28, 2025 13:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CAPA: Release v29.6.0. #1550

CAPA: Release v29.6.0. #1550

AndiDog commented Jan 23, 2025

tityosbot commented Jan 23, 2025

AndiDog commented Jan 23, 2025

tinkerers-ci bot commented Jan 23, 2025

AndiDog commented Jan 23, 2025

Gacko commented Jan 23, 2025

Gacko commented Jan 23, 2025

tinkerers-ci bot commented Jan 23, 2025

AndiDog Jan 23, 2025

AndiDog Jan 23, 2025

njuettner left a comment

Gacko left a comment

Gacko commented Jan 27, 2025

AndiDog commented Jan 28, 2025

Gacko left a comment

Gacko commented Jan 28, 2025

Gacko commented Jan 28, 2025

AndiDog left a comment

ubergesundheit left a comment

tinkerers-ci bot commented Jan 28, 2025

T-Kukawka commented Jan 28, 2025

Gacko commented Jan 28, 2025

tinkerers-ci bot commented Jan 28, 2025

		@@ -0,0 +1,88 @@
		# :zap: Giant Swarm Release v29.6.0 for CAPA :zap:

		<< Add description here >>

		@@ -0,0 +1,3 @@
		Workload cluster release v29.6.0 for CAPA is available. << Add description here >>

CAPA: Release v29.6.0. #1550

CAPA: Release v29.6.0. #1550

Conversation

AndiDog commented Jan 23, 2025

Checklist

tityosbot commented Jan 23, 2025

AndiDog commented Jan 23, 2025

tinkerers-ci bot commented Jan 23, 2025

AndiDog commented Jan 23, 2025

Gacko commented Jan 23, 2025

Gacko commented Jan 23, 2025

tinkerers-ci bot commented Jan 23, 2025

releases-test-suites

AndiDog Jan 23, 2025

Choose a reason for hiding this comment

AndiDog Jan 23, 2025

Choose a reason for hiding this comment

njuettner left a comment

Choose a reason for hiding this comment

Gacko left a comment

Choose a reason for hiding this comment

Gacko commented Jan 27, 2025

AndiDog commented Jan 28, 2025

Gacko left a comment

Choose a reason for hiding this comment

Gacko commented Jan 28, 2025

Gacko commented Jan 28, 2025

AndiDog left a comment

Choose a reason for hiding this comment

ubergesundheit left a comment

Choose a reason for hiding this comment

tinkerers-ci bot commented Jan 28, 2025

releases-test-suites

T-Kukawka commented Jan 28, 2025

Gacko commented Jan 28, 2025

tinkerers-ci bot commented Jan 28, 2025

releases-test-suites