This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Fix modules #63
Merged
Fix modules #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfussell
commented
Jul 28, 2020
| @@ -1,19 +1,11 @@ | |||
| module github.com/giantswarm/gsclientgen | |||
| module github.com/giantswarm/gsclientgen/v2 | |||
There was a problem hiding this comment.
Here is the main change.
tfussell
commented
Jul 28, 2020
| github.com/mailru/easyjson v0.0.0-20190403194419-1ea4449da983 // indirect | ||
| golang.org/x/net v0.0.0-20190509222800-a4d6f7feada5 // indirect | ||
| golang.org/x/text v0.3.2 // indirect | ||
| github.com/go-openapi/errors v0.19.6 |
There was a problem hiding this comment.
Using the latest released versions for each dep.
yulianedyalkova
approved these changes
Jul 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to import this library with
github.com/giantswarm/gsclientgen/v2because the module definition ingo.modwasn't updated to match the major version (required for v2+). I don't see any changes in the generated API specs (generated withmake, compared master with this branch usingdiff).