This repository was archived by the owner on Jan 4, 2024. It is now read-only.
Move machineInfrastructure from KubeadmControlPlaneTemplate to ClusterClass#46
Merged
Move machineInfrastructure from KubeadmControlPlaneTemplate to ClusterClass#46
Conversation
erkanerol
force-pushed
the
fix-schema-errors
branch
from
7acec12 to
be78be2
Compare
…rClass machineTemplate in KubeadmControlPlaneTemplate is removed with CAPI v1.1.0 See kubernetes-sigs/cluster-api#5788 We need to move that part to clusterClass
erkanerol
force-pushed
the
fix-schema-errors
branch
from
be78be2 to
7bf3d02
Compare
kopiczko
approved these changes
Feb 7, 2022
tfussell
reviewed
Feb 7, 2022
kopiczko
reviewed
Feb 7, 2022
Co-authored-by: Thomas Fussell <thomas@giantswarm.io>
tfussell
approved these changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
machineTemplateinKubeadmControlPlaneTemplateis removed with CAPI v1.1.0See kubernetes-sigs/cluster-api#5788
We need to move that part to
clusterClass.