Enable setting peering properties#16
Merged
Merged
Conversation
nprokopic
force-pushed
the
add-circle-ci-config
branch
from
d0cf6d7 to
b07f578
Compare
nprokopic
force-pushed
the
more-peering-properties
branch
2 times, most recently
from
d6d4da5 to
c81540f
Compare
nprokopic
force-pushed
the
add-circle-ci-config
branch
from
52ce1ca to
5dc575c
Compare
nprokopic
force-pushed
the
more-peering-properties
branch
from
cf395ee to
cea87be
Compare
bavarianbidi
approved these changes
Apr 3, 2023
| "testing" | ||
|
|
||
| "github.com/Azure/go-autorest/autorest" | ||
| "github.com/Azure/go-autorest/autorest/to" |
There was a problem hiding this comment.
according to the comment in kubernetes-sigs#3340 (comment)
I think we want to switch to the
"k8s.io/utils/pointer"library
we should use the k8s pointer library here as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#2041
We're running this already for some time.
Upstream CAPZ PR is here kubernetes-sigs#3340, it differs only in some code formatting, minor refactorings and it has more tests, but the implementation is the same.