Skip to content

Update docker kubectl image #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2022
Merged

Update docker kubectl image #78

merged 3 commits into from
Dec 19, 2022

Conversation

@nprokopic
Copy link
Contributor

@nprokopic nprokopic commented Dec 18, 2022 •
edited
Loading

Towards giantswarm/roadmap#1808

This PR is currently on top of upstream-update-v1.4.5 branch.

TODO:

Changes

  • Update docker-kubectl image version to v1.25.4

@nprokopic nprokopic marked this pull request as ready for review December 18, 2022 16:49
@nprokopic nprokopic requested a review from a team December 18, 2022 16:49
@nprokopic nprokopic self-assigned this Dec 18, 2022
@nprokopic nprokopic requested review from a team December 18, 2022 16:49
bavarianbidi
bavarianbidi approved these changes Dec 19, 2022
View reviewed changes
Copy link

@bavarianbidi bavarianbidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgm for CAPI (Clippy)

Note: PR wants to get merged on main. I guess the idea was similar to the previous PRs to get the diff as small as possible and (at least for the PR itself) point it to another branch. I've only take a look at values.yaml to see the version bump for kubectl

@nprokopic nprokopic changed the base branch from main to upstream-update-v1.4.5 December 19, 2022 09:31
@nprokopic
Copy link
Contributor Author

nprokopic commented Dec 19, 2022

Note: PR wants to get merged on main. I guess the idea was similar to the previous PRs to get the diff as small as possible and (at least for the PR itself) point it to another branch. I've only take a look at values.yaml to see the version bump for kubectl

Whoops, yeah you are right, forgot to change base branch, did it now 😬 It should be more clear.

@nprokopic nprokopic force-pushed the upstream-update-v1.4.5 branch from 6bc8c21 to d9e2df4 Compare December 19, 2022 10:40
@nprokopic nprokopic force-pushed the update-docker-kubectl-image branch 2 times, most recently from f68a862 to 02e4fc5 Compare December 19, 2022 10:54
Base automatically changed from upstream-update-v1.4.5 to main December 19, 2022 11:02
@nprokopic nprokopic force-pushed the update-docker-kubectl-image branch from 87b8a25 to 4add010 Compare December 19, 2022 11:08
@nprokopic nprokopic merged commit ff0722f into main Dec 19, 2022
@nprokopic nprokopic deleted the update-docker-kubectl-image branch December 19, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bavarianbidi bavarianbidi bavarianbidi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nprokopic nprokopic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nprokopic @bavarianbidi