Upstream update to v1.3.2 #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nprokopic
commented
Dec 17, 2022
| - ServicePrincipal | ||
| - ManualServicePrincipal | ||
| - UserAssignedMSI | ||
| - ServicePrincipalCertificate |
Contributor
Author
There was a problem hiding this comment.
This looks like a breaking change in theory, but in practice it is not, as UserAssignedMSI never worked, see this comment for more details.
In any case we should not be affected, because all vintage workload clusters are using ServicePrincipal type.
Contributor
There was a problem hiding this comment.
just for reference i did test it in capz 1.6.x and it worked for me using the UA assigned to the MC node
apparently the actual issue with UA Identity was fixed in CAPZ 1.4 kubernetes-sigs/cluster-api-provider-azure#1104
👍
nprokopic
commented
Dec 17, 2022
| type: string | ||
| description: AdditionalTags is an optional set of tags to add to Azure resources managed by the Azure provider, in addition to the ones added by default. | ||
| type: object | ||
| addonProfiles: |
Contributor
Author
There was a problem hiding this comment.
We are still not using CAPZ managed clusters, so not affected by this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/24551
Changes
Highlighted upstream changes that can be relevant for vintage workload clusters
(with specified upstream cluster-api-provider-azure versions)
v1.3.0Add support for Service Principal with Certificate auth using AAD pod identity. This looks like a breaking change in theory, sinceAzureClusterIdentityUserAssignedMSItype is removed, but in practice it is not, becauseUserAssignedMSInever worked, see this comment for more details. In any case Giant Swarm workload clusters are not be affected, because all of them are usingServicePrincipaltype (I checked all workload clusters that are deployed at the time of writing on 2022-12-17) and this breaking change is reverted in the next minor release.Upstream cluster-api-provider-azure release notes