Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Split AWS/IAM policies for master and workers #362

Closed
wants to merge 4 commits into from

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Jul 26, 2017

Fixes #330

@rossf7 rossf7 self-assigned this Jul 26, 2017
@rossf7
Copy link
Contributor Author

rossf7 commented Jul 26, 2017

Creating separate policies works but the worker policy now has restricted EC2 permissions. This is as per the cloud provider docs but I need to test the persistent volumes still work.

@hobti01
Copy link
Contributor

hobti01 commented Jul 31, 2017

@rossf7 could you please add the following to the policy on the master and workers to allow image pulling from ECR as implemented in kubernetes/kubernetes#19447 and kubernetes/kubernetes#24369

See also PR #364

{
"Effect": "Allow",
    "Action": [
        "ecr:GetAuthorizationToken",
        "ecr:BatchCheckLayerAvailability",
        "ecr:GetDownloadUrlForLayer",
        "ecr:GetRepositoryPolicy",
        "ecr:DescribeRepositories",
        "ecr:ListImages",
        "ecr:BatchGetImage"
    ],
    "Resource": "*"
}

@rossf7
Copy link
Contributor Author

rossf7 commented Aug 1, 2017

Hi @hobti01 I think it's best that this is handled as a separate change. Thanks for providing your PR we'll get that reviewed.

@rossf7
Copy link
Contributor Author

rossf7 commented Aug 9, 2017

Closing as this was implemented in #370. ECR permissions are now only applied to worker nodes.

@rossf7 rossf7 closed this Aug 9, 2017
@rossf7 rossf7 deleted the iam-policies branch August 9, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants