Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Helm version bump #95

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Disable Helm version bump #95

merged 2 commits into from
Mar 10, 2020

Conversation

yasn77
Copy link

@yasn77 yasn77 commented Mar 9, 2020

Since we use architect to bump the version of Helm chart, this check isn't
needed. It can in fact lead to false failures as it fails to understand the last
version.

🔧 Please make sure to familiarize yourself with Development section of README.md before releasing a PR to this repository.

⚠️ If you want to create a new release of this orb please read Releases section of README.md carefully ❗

Checklist

  • Update changelog in CHANGELOG.md.
  • After the release update architect orb version in .circleci/config.yml.

Yasser Saleemi added 2 commits March 10, 2020 11:06
Since we use architect to bump the version of Helm chart, this check isn't
needed. It can in fact lead to false failures as it fails to understand the last
version.
@yasn77 yasn77 force-pushed the disable_helm_version_bump branch from 5418a04 to 8510ac2 Compare March 10, 2020 11:08
@yasn77 yasn77 merged commit 38bfea7 into master Mar 10, 2020
@yasn77 yasn77 deleted the disable_helm_version_bump branch March 10, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants