Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some mistakes of the original cluster labelling PR #203

Merged
merged 1 commit into from
May 6, 2020
Merged

Fix some mistakes of the original cluster labelling PR #203

merged 1 commit into from
May 6, 2020

Conversation

ubergesundheit
Copy link
Member

Follow-up to #196

Improvements over #196:

  • Adds the usual header parameters to getClusterLabels & setClusterLabels
  • Adds separate Request definition. Right now Request & Response share one definition which is confusing in generated clients IMO
  • Renaming of V5ListClustersByLabel to make it clear it is a Request definition

@ubergesundheit ubergesundheit requested a review from a team May 6, 2020 06:39
@ubergesundheit ubergesundheit changed the title fix some mistakes of the original PR Fix some mistakes of the original cluster labelling PR May 6, 2020
stone-z
stone-z approved these changes May 6, 2020
View reviewed changes
Copy link

@stone-z stone-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with how this works, but looks sensible to me

MarcelMue
MarcelMue approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@MarcelMue MarcelMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible.

@ubergesundheit ubergesundheit merged commit 656c413 into master May 6, 2020
@ubergesundheit ubergesundheit deleted the cluster-labelling-followup branch May 6, 2020 08:33
@ubergesundheit ubergesundheit mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelMue MarcelMue MarcelMue approved these changes

@stone-z stone-z stone-z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ubergesundheit @MarcelMue @stone-z