Fix GIL warnings and a few thread-safety issues in free-threaded CPython #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The temporary `argv` C array is no longer global in OpenBSD's proc_cmdline - The `maxcpus` variable is no longer global in FreeBSD's per_cpu_times. Signed-off-by: Sam Gross <[email protected]>
colesbury
force-pushed
the
gil-free-threaded
branch
from
f0a5465
to
5c0c089
Compare
giampaolo
requested changes
Jun 24, 2024
psutil/arch/openbsd/proc.c
Outdated
| return py_retlist; | ||
|
|
||
| error: | ||
| free(argv); |
There was a problem hiding this comment.
Shouldn't this be?
if (argv != NULL)
free(argv);There was a problem hiding this comment.
free() handles NULL pointers, but I can add the if (argv != NULL) guard if you prefer that style.
There was a problem hiding this comment.
Thank you.
Side story: years ago psutil received a CVE due to a double free(), so I believe I started using this style since then.
There was a problem hiding this comment.
Double free is a separate issue: to avoid that you can use the coding style:
free(p);
p = NULL;
Signed-off-by: Sam Gross <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
This adds
PyUnstable_Module_SetGILcalls to allowpsutilto run with the GIL disabled in the CPython free-threading builds. This also fixes a few thread-safety that could cause problems with the GIL disabled:argvC array is no longer global in OpenBSD'sproc_cmdlinemaxcpusvariable is no longer global in FreeBSD'sper_cpu_times.