-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wheels: add arm64 builds #2224
wheels: add arm64 builds #2224
Conversation
- add arm64, ppc64le, s390x builds via qemu - add macos universal2 build - add windows arm64 build - bump cancel workflow action to latest to remove nodejs warnings - bump cibuildwheel action to latest Signed-off-by: Aaron Shaw <[email protected]>
(everything related to musllinux was copied from #2126 yet not even mentioned in the PR description...) |
@giampaolo This PR looks very promising. |
Ran into the same issue just now when debugging a Docker image on a MacBook Air M1. Would be great if there were arm64 wheels on PyPI. |
@ben9923 I didn't copy anything from your PR but happy to add attribution and combine them since yours clearly came before mine. You probably should have reached out to me privately though before making false accusations of this kind though! |
I highly doubt those package install commands made to run, for example, some missing network tests (on already supported platforms) came from nowhere, but anyway mostly said it because your PR description doesn't even mention any of the changes that are highlighted in my PR and are included in yours. I don't really care about the credit for some yaml lines, just want some wheels 😛 |
@ben9923 anyone who was trying to get this to work with tests passing etc would have to add the same stuff. So it's hardly a surprise. I was originally trying to get PyPy to work too as well as some builds for py2 on Windows but ran out of time and gave up on those bits as they were non essential for what I was doing at the time. In any case, as you say, just need more wheels so hopefully this gets pulled in one way or another 👍😎 |
I have also run into this issue. |
Hey this looks promising! I can't tell from the diff. Would this yield an arm64 wheel for python 3.12 or just some older versions? |
Adding my upvote to get this merged. In my experience, lots of tech companies now supply devs with Mac laptops that are For anyone looking for workarounds in the meantime, I've found a few options:
|
Just FWIW, GitHub now offers free standard GHA runners for macOS arm64, and to my understanding there are active plans to offer Linux and Windows arm64 support within the next ≈year. |
Hello, may I ask what the current status of this is? Do you need any more work or testing to be done before this PR will be considered for a merge? Thanks! cc @larsoner |
@hoechenberger I'm not sure. Happy to do more work to get it merged but haven't heard anything on this from @giampaolo since opening the PR so unclear what the status is sadly 😕 |
Hello @giampaolo, what are your thoughts on this? This is something that's important e.g. to users on Apple Silicon. |
@giampaolo #2425 does not close this PR and is missing a bunch of stuff from it. Real shame that after all this you have just closed this PR and fixed just a subset of the issues. |
@giampaolo at the very least can you merge #2126 or something similar please |
@shawaj: sorry for closing this out, but the PR I just merged predated your PR (see original #2103 from 2 years ago). Also the changes to The exclusion of As to why I've refrained from adding new builds / architectures to the CI matrix for so long see old #2103 (comment). Nothing personal here, it's just that this is a big project and I'm alone, so I'm cautious with adding extra work which I know I won't be able to keep up with. |
Summary
Description