Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assertEqual instead of assertEquals for Python 3.11 compatibility. #1995

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Use assertEqual instead of assertEquals for Python 3.11 compatibility. #1995

merged 1 commit into from
Oct 8, 2021

Conversation

tirkarthi
Copy link
Contributor

Summary

  • OS: Ubuntu
  • Bug fix: yes
  • Type: tests

Description

Deprecated unittest aliases were removed in Python 3.11 in python/cpython#28268 . This is the only instance in the codebase as per command below.

rg -t py 'assertEquals|assertNotEquals|assertAlmostEquals|assertNotAlmostEquals|assertRegexpMatches|assertNotRegexpMatches|assertRaisesRegexp|failUnlessEqual|failIfEqual|failUnlessAlmostEqual|failUnless|failUnlessRaises|failIf'

@giampaolo giampaolo merged commit abbf5e4 into giampaolo:master Oct 8, 2021
@tirkarthi
Copy link
Contributor Author

Thanks @giampaolo

@giampaolo
Copy link
Owner

giampaolo commented Oct 8, 2021 •
edited
Loading

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tirkarthi @giampaolo