Add CPU frequency support for FreeBSD #1369

amanusk · 2018-11-30T07:49:01Z

This adds support for CPU frequency on FreeBSD. (Addresses #1352)
An example sysctl call looks like this:

dev.cpu.0.freq_levels: 2701/45000 2700/45000 2600/42708 2500/40461 2400/38257 2300/36525 2200/34401 2100/32327 1900/28698 1800/26736 1700/24815 1600/23334 1500/21489 1400/19683 1300/18298 1200/16566
dev.cpu.0.freq: 1200

Frequency reading is only available for core 0, as explained here: https://stackoverflow.com/questions/9941664/how-to-get-real-cpu-frequency-while-system-running

The available frequency levels are in the format (frequency/power usage) (as per https://www.unix.com/man-page/FreeBSD/4/cpufreq/).
To my knowledge, in this example the top frequency level is 2701, and the one after it is 2700. The 1 indicates that Turbo frequency is enabled, but I do not know of a way to get the actual frequency (obviously this should more than 1 MHz :) . On this system the Turbo frequency is 3.3GHz when running on all cores)

Example command line:

[~/psutil]> python3 -c "import psutil; print(psutil.cpu_freq())"
scpufreq(current=2701, min='1200', max='2701')

(I will add tests after initial review)

giampaolo

Thanks a lot Alex. I added some inline comments but overall it's a great piece of work.

giampaolo · 2018-11-30T18:50:58Z

psutil/_psbsd.py

+        num_cpus = cpu_count_logical()
+        for cpu in range(num_cpus):
+            try:
+                current, available = cext.cpu_frequency(cpu)


This try/except block is too broad. It should only wrap the cext.cpu_frequency(cpu) line.
Also consider renaming available to minmax or something.

giampaolo · 2018-11-30T18:52:41Z

psutil/_psbsd.py

+                high = None
+                if available:
+                    try:
+                        low = int(available.split(" ")[-1].split("/")[0])


Mmm. How does the string (available) look like in here?

The available line looks like this:
2701/45000 2700/45000 2600/42708 2500/40461 2400/38257 2300/36525 2200/34401 2100/32327 1900/28698 1800/26736 1700/24815 1600/23334 1500/21489 1400/19683 1300/18298 1200/16566

It represents all the available levels of frequency the CPU can be in, not just min/max, that's why I thought it would be a better name

giampaolo · 2018-11-30T18:53:12Z

psutil/_psutil_bsd.c

@@ -983,6 +983,8 @@ PsutilMethods[] = {
     "Return battery information."},
    {"sensors_cpu_temperature", psutil_sensors_cpu_temperature, METH_VARARGS,
     "Return temperature information for a given CPU core number."},
+    {"cpu_frequency", psutil_cpu_freq, METH_VARARGS,
+     "Return cpu 0 frequency"},


Shouldn't this be "Return frequency of a given CPU"?

giampaolo · 2018-11-30T18:53:39Z

psutil/arch/freebsd/specific.c

+
+
+/*
+ * Return cpu 0 frequency information


Same here ("Return frequency of a given CPU number")

giampaolo · 2018-11-30T18:54:02Z

psutil/arch/freebsd/specific.c

+        goto error;
+
+    size = sizeof(available);
+    // In case of faliure, an empty string is returned


typo (faliure)

giampaolo · 2018-11-30T18:54:37Z

psutil/arch/freebsd/specific.c

+    int core;
+    char sensor[26];
+    char available[1000];
+    char* answer;


It appears this is not used.

giampaolo · 2018-11-30T18:58:14Z

psutil/arch/freebsd/specific.c

+    int max;
+    int core;
+    char sensor[26];
+    char available[1000];


Maybe it makes more sense to rename this to minmax or something (assuming that's what the string represents, which I don't know).

The string represents all available CPU frequency levels

Add test for cpu_freq() and fix review comments

giampaolo · 2018-12-01T18:15:24Z

Thanks Alex.

@EccoTheFlintstone

* origin/master: (182 commits) giampaolo#1394 / windows / process exe(): convert errno 0 into ERROR_ACCESS_DENIED; errno 0 occurs when the Python process runs in 'Virtual Secure Mode' pre-release fix win num_handles() test update readme fix giampaolo#1111: use a lock to make Process.oneshot() thread safe pdate HISTORY giampaolo#1373: different approach to oneshot() cache (pass Process instances around - which is faster) use PROCESS_QUERY_LIMITED_INFORMATION also for username() Linux: refactor _parse_stat_file() and return a dict instead of a list (+ maintainability) fix giampaolo#1357: do not expose Process' memory_maps() and io_counters() methods if not supported by the kernel giampaolo#1376 Windows: check if variable is NULL before free()ing it enforce lack of support for Win XP fix giampaolo#1370: improper usage of CloseHandle() may lead to override the original error code resulting in raising a wrong exception update HISTORY (Windows) use PROCESS_QUERY_LIMITED_INFORMATION access rights (giampaolo#1376) update HISTORY revert 5398c48; let's do it in a separate branch giampaolo#1111 make Process.oneshot() thread-safe sort HISTORY give CREDITS to @EccoTheFlintstone for giampaolo#1368 fix ionice set not working on windows x64 due to LENGTH_MISMATCH (giampaolo#1368) make flake8 happy give CREDITS to @amanusk for giampaolo#1369 / giampaolo#1352 and update doc Add CPU frequency support for FreeBSD (giampaolo#1369) giampaolo#1359: add test case for cpu_count(logical=False) against lscpu utility disable false positive mem test on travis + osx fix PEP8 style mistakes give credits to @koenkooi for giampaolo#1360 Fix giampaolo#1354 [Linux] disk_io_counters() fails on Linux kernel 4.18+ (giampaolo#1360) giampaolo#1350: give credits to @amanusk FreeBSD adding temperature sensors (WIP) (giampaolo#1350) pre release sensors_temperatures() / linux: convert defaultdict to dict fix giampaolo#1004: Process.io_counters() may raise ValueError fix giampaolo#1307: [Linux] disk_partitions() does not honour PROCFS_PATH refactor hasattr() checks as global constants giampaolo#1197 / linux / cpu_freq(): parse /proc/cpuinfo in case /sys/devices/system/cpu fs is not available fix giampaolo#1277 / osx / virtual_memory: 'available' and 'used' memory were not calculated properly travis / osx: set py 3.6 travis: disable pypy; se py 3.7 on osx skip test on PYPY + Travis fix travis fix giampaolo#715: do not print exception on import time in case cpu_times() fails. fix different travis failures give CREDITS for giampaolo#1320 to @truthbk [aix] improve compilation on AIX, better support for gcc/g++ + fix cpu metrics (giampaolo#1320) give credits to @alxchk for giampaolo#1346 (sunOS) Fix giampaolo#1346 (giampaolo#1347) giampaolo#1284, giampaolo#1345 - give credits to @amanusk Add parsing for /sys/class/thermal (giampaolo#1345) Fix decoding error in tests catch UnicodeEncodeError on print() use memory tolerance in occasionally failing test Fix random 0xC0000001 errors when querying for Connections (giampaolo#1335) Correct capitalization of PyPI (giampaolo#1337) giampaolo#1341: move open() utilities/wrappers in _common.py Refactored ps() function in test_posix (giampaolo#1341) fix giampaolo#1343: document Process.as_dict() attrs values giampaolo#1332 - update HISTORY make psutil_debug() aware of PSUTIL_DEBUG (giampaolo#1332) also include PYPY (or try to :P) travis: add python 3.7 build add download badge remove failing test assertions remove failing test make test more robust pre release pre release set version to 5.4.7 OSX / SMC / sensors: revert giampaolo#1284 (giampaolo#1325) setup.py: add py 3.7 fix giampaolo#1323: [Linux] sensors_temperatures() may fail with ValueError fix failing linux tests giampaolo#1321 add unit tests giampaolo#1321: refactoring make disk_io_counters more robust (giampaolo#1324) fix typo Fix DeprecationWarning: invalid escape sequence (giampaolo#1318) remove old test update is_storage_device() docstring fix giampaolo#1305 / disk_io_counters() / Linux: assume SECTOR_SIZE is a fixed 512 giampaolo#1313 remove test which no longer makes sense disk_io_counters() - linux: mimic iostat behavior (giampaolo#1313) fix wrong reference link in doc disambiguate TESTFN for parallel testing fix giampaolo#1309: add STATUS_PARKED constant and fix STATUS_IDLE (both on linux) give CREDITS to @sylvainduchesne for giampaolo#1294 retain GIL when querying connections table (giampaolo#1306) Update index.rst (giampaolo#1308) fix giampaolo#1279: catch and skip ENODEV in net_if_stat() appveyor: retire 3.5, add 3.7 revert file renaming of macos files; get them back to 'osx' prefix winmake: add upload-wheels cmd Rename OSX to macOS (giampaolo#1298) apveyor: reset py 3.4 and remove 3.7 (not available yet) try to fix occasional children() failure on Win: https://ci.appveyor.com/project/giampaolo/psutil/build/job/je3qyldbb86ff66h appveyor: remove py 3.4 and add 3.7 giampaolo#1284: give credits to @amanusk + some minor adjustments little refactoring Osx temps (giampaolo#1284) ...

amanusk added 2 commits November 30, 2018 07:31

Add CPU frequency support for FreeBSD

349ee35

Cast min and max frequency to int

59589f8

giampaolo requested changes Nov 30, 2018

View reviewed changes

Add test for FreeBSD cpu_freq()

86797d5

Add test for cpu_freq() and fix review comments

giampaolo merged commit 459556d into giampaolo:master Dec 1, 2018

giampaolo added a commit that referenced this pull request Dec 1, 2018

give CREDITS to @amanusk for #1369 / #1352 and update doc

fd0b6d7

giampaolo added freebsd enhancement labels Nov 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CPU frequency support for FreeBSD #1369

Add CPU frequency support for FreeBSD #1369

amanusk commented Nov 30, 2018

giampaolo left a comment

giampaolo Nov 30, 2018

giampaolo Nov 30, 2018

amanusk Dec 1, 2018

giampaolo Nov 30, 2018

amanusk Dec 1, 2018

giampaolo Nov 30, 2018

giampaolo Nov 30, 2018

amanusk Dec 1, 2018

giampaolo Nov 30, 2018

amanusk Dec 1, 2018

giampaolo Nov 30, 2018

amanusk Dec 1, 2018

giampaolo commented Dec 1, 2018

Add CPU frequency support for FreeBSD #1369

Add CPU frequency support for FreeBSD #1369

Conversation

amanusk commented Nov 30, 2018

giampaolo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giampaolo commented Dec 1, 2018