Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest instead of unittest #2446

Closed
giampaolo opened this issue Oct 1, 2024 · 1 comment
Closed

Use pytest instead of unittest #2446

giampaolo opened this issue Oct 1, 2024 · 1 comment

Comments

@giampaolo
Copy link
Owner

giampaolo commented Oct 1, 2024

I recently did this for pyftpdlib giampaolo/pyftpdlib#628.

Reasons:

@github-actions github-actions bot added the tests label Oct 1, 2024
giampaolo added a commit that referenced this issue Oct 1, 2024
See #2446.

This PR:

* gets rid of [psutil/tests/runner.py](https://github.com/giampaolo/psutil/blob/622bd442eef704627202282d5805e4b39358b897/psutil/tests/runner.py#L1) (less code to maintain)
* use `pytest-xdist` to allow for parallel test execution
* get rid of [concurrencytest](https://pypi.org/project/concurrencytest/) dep
* update Github and Appveyor CI config
* removes 400 lines of code

Replacing `self.assert*` APIs will  be done in a separate PR.
@giampaolo
Copy link
Owner Author

giampaolo commented Oct 3, 2024

Fixed in #2447, #2453, #2456, #2459, #2461.

giampaolo added a commit that referenced this issue Oct 15, 2024
)

This is the 4th (and hopefully last) step of #2446. Similarly to #2456, we emulate @pytest.mark.skipif via unittest if pytest is not installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant