#921: add Popen.__del__ to help the GC freeing resources

HISTORY.rst

@@ -37,6 +37,8 @@ Bug tracker at https://github.com/giampaolo/psutil/issues
   OSError with no exception set if process is gone.
 - #916: [OSX] fix many compilation warnings.
 - #918: [NetBSD] all memory metrics were wrong.
+- #921: psutil.Popen now defines a __del__ special method which calls the
+  original one, hopefully helping the gc to free resources.
 
 
 4.3.1 - 2016-09-01

psutil/__init__.py

@@ -1264,6 +1264,10 @@ def __init__(self, *args, **kwargs):
     def __dir__(self):
         return sorted(set(dir(Popen) + dir(subprocess.Popen)))
 
+    def __del__(self, *args, **kwargs):
+        self.__subproc.__del__(*args, **kwargs)
+        self.__subproc = None
+
     def __enter__(self):
         if hasattr(self.__subproc, '__enter__'):
             self.__subproc.__enter__()

psutil/tests/__init__.py

@@ -204,7 +204,7 @@ def get_test_subprocess(cmd=None, **kwds):
         pyline += "sleep(60)"
         cmd = [PYTHON, "-c", pyline]
         sproc = subprocess.Popen(cmd, **kwds)
-        wait_for_file(TESTFN, empty=True)
+        wait_for_file(TESTFN, delete_file=True, empty=True)
     else:
         sproc = subprocess.Popen(cmd, **kwds)
         wait_for_pid(sproc.pid)

psutil/tests/test_linux.py

@@ -564,7 +564,7 @@ def test_net_if_stats(self):
             except RuntimeError:
                 pass
             else:
-                self.assertEqual(stats.isup, 'RUNNING' in out)
+                self.assertEqual(stats.isup, 'RUNNING' in out, msg=out)
                 self.assertEqual(stats.mtu,
                                  int(re.findall('MTU:(\d+)', out)[0]))