add a fix-unittests make target to fix unit tests

thanks to https://github.com/isidentical/teyit and @isidentical

Signed-off-by: Giampaolo Rodola <[email protected]>

Makefile

@@ -28,6 +28,7 @@ PY3_DEPS = \
 	requests \
 	setuptools \
 	sphinx_rtd_theme \
+	teyit \
 	twine \
 	virtualenv \
 	wheel
@@ -225,9 +226,13 @@ fix-flake8:  ## Run autopep8, fix some Python flake8 / pep8 issues.
 fix-imports:  ## Fix imports with isort.
 	@git ls-files '*.py' | xargs $(PYTHON) -m isort --jobs=${NUM_WORKERS}
 
+fix-unittests:  ## Fix unittest idioms.
+	@git ls-files '*test_*.py' | xargs $(PYTHON) -m teyit --show-stats
+
 fix-all:  ## Run all code fixers.
 	${MAKE} fix-flake8
 	${MAKE} fix-imports
+	${MAKE} fix-unittests
 
 # ===================================================================
 # GIT

psutil/tests/test_system.py

@@ -263,7 +263,7 @@ def test_os_constants(self):
 
         # assert all other constants are set to False
         for name in names:
-            self.assertIs(getattr(psutil, name), False, msg=name)
+            self.assertFalse(getattr(psutil, name), msg=name)
 
 
 class TestMemoryAPIs(PsutilTestCase):

psutil/tests/test_windows.py

@@ -374,15 +374,15 @@ def test_special_pid(self):
         # that nothing strange happens
         str(p)
         p.username()
-        self.assertTrue(p.create_time() >= 0.0)
+        self.assertGreaterEqual(p.create_time(), 0.0)
         try:
             rss, vms = p.memory_info()[:2]
         except psutil.AccessDenied:
             # expected on Windows Vista and Windows 7
             if not platform.uname()[1] in ('vista', 'win-7', 'win7'):
                 raise
         else:
-            self.assertTrue(rss > 0)
+            self.assertGreater(rss, 0)
 
     def test_send_signal(self):
         p = psutil.Process(self.pid)