Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk: use language-neutral arrows for resize overlays #6013

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

pluiedev
Copy link
Member

The meaning of "c" and "r" can be somewhat cryptic to non-native English speakers as it may not be immediately obvious that "c" stands for "columns", and "r" stands for "rows". I propose replacing them with left-right and up-down double-headed arrows that convey the same meaning, but in a truly language-neutral manner.

Related to #2357

The meaning of "c" and "r" can be somewhat cryptic to non-native English
speakers as it may not be immediately obvious that "c" stands for "columns",
and "r" stands for "rows". I propose replacing them with left-right and
up-down double-headed arrows that convey the same meaning, but in a
truly language-neutral manner.

Related to ghostty-org#2357
@pluiedev pluiedev requested a review from a team as a code owner February 27, 2025 07:42
Copy link
Member

@jcollie jcollie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

↔ and ↕ are supported in both Cantarell and the new Adwaita fonts so any issues displaying these are on the user for choosing something other than the Gnome defaults.

@jcollie jcollie merged commit ef7f8cb into ghostty-org:main Feb 27, 2025
29 checks passed
@github-actions github-actions bot added this to the 1.2.0 milestone Feb 27, 2025
@tristan957
Copy link
Collaborator

What if we just did rows x columns with no extra symbol. This is what Ptyxis does for example

@jcollie
Copy link
Member

jcollie commented Feb 27, 2025

What if we just did rows x columns with no extra symbol. This is what Ptyxis does for example

Measurements without units? I'd say that's more confusing than not knowing what c and r mean. Sure, you can usually tell from the context but that's extra moments spent thinking about it when we can just include the units and be unambiguous about it.

@pluiedev
Copy link
Member Author

pluiedev commented Feb 27, 2025

but that's extra moments spent thinking about it when we can just include the units and be unambiguous about it.

This exactly. From an admittedly English-as-a-second-language perspective it always takes me a moment to register what "c" and "r" even mean, and just numbers would make that even worse 😅

@tristan957
Copy link
Collaborator

I typically expect GNOME designers to know what they are doing 🤷. GNOME Console also has no units

@pluiedev
Copy link
Member Author

Who knows? Maybe other designers would think of this as a better idea. We were already deviating from the norm per se, and nobody seems to have complained thus far

@tristan957
Copy link
Collaborator

Internally I was complaining 😆

@tristan957
Copy link
Collaborator

I do think this is an improvement over the previous version due to the mentioned language barrier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants