Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk: work around oversized drag handle for GtkPaned #6000

Merged

Conversation

daviewales
Copy link
Contributor

Improves #3020.

Based on recommendation from upstream Gtk issue:
https://gitlab.gnome.org/GNOME/gtk/-/issues/4484#note_2362002

Without this, it's not possible to select the first character on the right-hand side of a split.

@daviewales daviewales requested a review from a team as a code owner February 26, 2025 11:22
@pluiedev
Copy link
Member

Is this mutually exclusive with #6002, or do they supplement each other?

@daviewales
Copy link
Contributor Author

This is a hopefully noncontroversial subset of #6002. They share commit 33e1930, which works around a Gtk bug which causes the pane drag handle to be oversized. This improves the issue, as it was previously not possible to select the first character in a right-hand split pane. With this PR it is possible if you start around halfway through the character. It's not a complete fix, as the drag handle still covers the left half of the first character in the right pane.

This PR is attempting to get something similar into Gtk upstream:
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/8238

#6002 adds an extra commit to enable a wide handle for the pane separator, which functionally resolves the issue completely, but has some style issues.

My thinking is that this PR can hopefully be merged without too much trouble, and then #6002 can take a bit longer to figure out the best complete solution.

@tristan957
Copy link
Collaborator

Thanks for working with upstream!

@daviewales daviewales force-pushed the reduce-gtk-paned-separator-drag-width branch from 33e1930 to 02e25bf Compare February 27, 2025 06:08
Improves ghostty-org#3020.

Based on recommendation from upstream Gtk issue:
https://gitlab.gnome.org/GNOME/gtk/-/issues/4484#note_2362002

Without this, it's not possible to select the first character on the
right-hand side of a split.
@daviewales daviewales force-pushed the reduce-gtk-paned-separator-drag-width branch from 02e25bf to 63ea1ab Compare February 27, 2025 08:17
@jcollie jcollie merged commit 31df9d5 into ghostty-org:main Feb 27, 2025
29 checks passed
@github-actions github-actions bot added this to the 1.2.0 milestone Feb 27, 2025
@daviewales daviewales deleted the reduce-gtk-paned-separator-drag-width branch February 27, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants