Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk: switch dbus operations in src/apprt/gtk/App.zig to zig-gobject #5996

Merged
merged 1 commit into from
Feb 26, 2025
Merged

gtk: switch dbus operations in src/apprt/gtk/App.zig to zig-gobject #5996

merged 1 commit into from
Feb 26, 2025

Conversation

jcollie
Copy link
Member

@jcollie jcollie commented Feb 26, 2025

No description provided.

@jcollie jcollie requested a review from a team as a code owner February 26, 2025 04:56
tristan957
tristan957 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@tristan957 tristan957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we depend on libadwaita, I think we can just remove this code. We just subscribe to the style manager, but any removal should probably happen after this translation is merged. What do you think?

@jcollie
Copy link
Member Author

jcollie commented Feb 26, 2025

Now that we depend on libadwaita, I think we can just remove this code. We just subscribe to the style manager, but any removal should probably happen after this translation is merged. What do you think?

Yeah, I think we'll tackle that in a new PR.

@jcollie jcollie merged commit dec14f3 into ghostty-org:main Feb 26, 2025
29 checks passed
@jcollie jcollie deleted the gtk-dbus-gobject-update branch February 26, 2025 17:17
@github-actions github-actions bot added this to the 1.2.0 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristan957 tristan957 tristan957 approved these changes

Assignees
No one assigned
Labels
os/linux
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jcollie @tristan957