Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elvish sudo integration and update documentation #5992

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Yappaholic
Copy link
Contributor

Elvish integration is broken when running sudo, because the function sudo-with-terminfo uses command command, which is not implemented in Elvish. Changing it to external command should fix possible error when bypassing aliases, functions and builtins, like command does in Bash.
Discussion about this issue: #5979

Also I updated documentation about Elvish integration to provide fix when using use ghostty-integration outside of Ghostty with rc.elv.

@Yappaholic Yappaholic requested a review from a team as a code owner February 25, 2025 20:27
@mitchellh
Copy link
Contributor

I don't use elvish but googling backs this up and the docs improvements are appreciated.

@mitchellh mitchellh enabled auto-merge February 25, 2025 21:43
@mitchellh mitchellh merged commit c068390 into ghostty-org:main Feb 25, 2025
29 checks passed
@github-actions github-actions bot added this to the 1.2.0 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants