-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty keybind setting #5977
Fix empty keybind setting #5977
Conversation
b8097ee
to
a38f34c
Compare
a38f34c
to
22d99f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One easy request.
A couple notes for the future (we should NOT do them in this PR, just to keep things simple, but can follow up):
-
We should move the keybindings out to a dedicated file. They've been causing too much noise in
Config.zig
for too long and this reminded me.src/config/keybinding.zig
or something. -
We should make a
src/cli/args.init
function that takes a struct and uses comptime to find all the fields that have aninit
and call them so that we have one place we can always use to default any "config" structure (we use args for other stuff too).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, one small thing. I'd fix it myself but not at a PC rn.
Perfect. Thanks! |
No worries! I can work on the followups when I get the chance. |
Fixes #5936.
Extracts the default keybind setting to an
init
function. Add logic to callinit
inparseIntoField
if it is defined for the type.