-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gtk: switch clipboard confirmation to zig-gobject and blueprints #5968
gtk: switch clipboard confirmation to zig-gobject and blueprints #5968
Conversation
I agree with everything @pluiedev said. Good work so far. |
11575ec
to
5a73fa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the naming convention (as in, I think we can do better). The rest looks great.
Yeah, I think that I have it nailed down. Gotta do some testing and add some docs. |
502db17
to
497df57
Compare
Note that for Debian 12, the blueprints must be compiled on a distro with a newer version of `blueprint-compiler` and the raw UI XML committed to git. Debian 12 includes `blueprint-compiler` 0.6.0 which doesn't support compiling `adw.MessageDialog` even though the version of `libadwaita` supports it.
497df57
to
62dcddb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that for Debian 12, the blueprints must be compiled on a distro with a newer version of
blueprint-compiler
and the raw UI XML committed to git. Debian 12 includesblueprint-compiler
0.6.0 which doesn't support compilingadw.MessageDialog
even though the version oflibadwaita
supports it.