Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk: switch clipboard confirmation to zig-gobject and blueprints #5968

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

jcollie
Copy link
Member

@jcollie jcollie commented Feb 24, 2025

Note that for Debian 12, the blueprints must be compiled on a distro with a newer version of blueprint-compiler and the raw UI XML committed to git. Debian 12 includes blueprint-compiler 0.6.0 which doesn't support compiling adw.MessageDialog even though the version of libadwaita supports it.

@jcollie jcollie requested a review from a team as a code owner February 24, 2025 16:47
@tristan957
Copy link
Collaborator

I agree with everything @pluiedev said. Good work so far.

@jcollie jcollie force-pushed the gtk-clipboard-confirmation-update branch from 11575ec to 5a73fa3 Compare February 24, 2025 18:58
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the naming convention (as in, I think we can do better). The rest looks great.

@jcollie
Copy link
Member Author

jcollie commented Feb 24, 2025

I agree with the naming convention (as in, I think we can do better).

Yeah, I think that I have it nailed down. Gotta do some testing and add some docs.

@jcollie jcollie force-pushed the gtk-clipboard-confirmation-update branch 2 times, most recently from 502db17 to 497df57 Compare February 25, 2025 00:20
@jcollie jcollie requested a review from pluiedev February 25, 2025 02:40
Note that for Debian 12, the blueprints must be compiled on a distro
with a newer version of `blueprint-compiler` and the raw UI XML
committed to git. Debian 12 includes `blueprint-compiler` 0.6.0 which
doesn't support compiling `adw.MessageDialog` even though the version of
`libadwaita` supports it.
@jcollie jcollie force-pushed the gtk-clipboard-confirmation-update branch from 497df57 to 62dcddb Compare February 25, 2025 19:46
Copy link
Member

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pluiedev pluiedev merged commit 4e5e4a7 into ghostty-org:main Feb 25, 2025
29 checks passed
@github-actions github-actions bot added this to the 1.2.0 milestone Feb 25, 2025
@jcollie jcollie deleted the gtk-clipboard-confirmation-update branch February 26, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants