Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: fix crosshair verticalText and contextMenu pointerStyles #5933

Closed
wants to merge 2 commits into from

Conversation

monsterkodi
Copy link

fixes three mouse pointer styles that weren't working on macOS.

@monsterkodi monsterkodi requested a review from a team as a code owner February 22, 2025 19:39
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, modifying this in the back port isn't exactly right because back port is only supposed to match the real version directly. We may have to introduce a non-backport structure/view helper to add our pointer style.

Sorry to make this complicated, but the way it's implemented now if we ever dropped support for macOS versions that don't support pointerStyle then we'd get breakage.

@monsterkodi
Copy link
Author

unfortunately, i don't understand what you are saying :)
are you talking about the contextMenu style being implemented differently?
if yes, we could just remove the fix for the contextMenustyle and still get the other two styles working?

@monsterkodi
Copy link
Author

i honestly tried to understand the problem, but i couldn't figure it out :(

since i don't want to spoil your PR list (and my mind with this unfinished business ;) i will close it. i am sure someone more capable than me will be able to solve this properly at some point or you will find the time to do it yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants