gtk: fix building on Debian 12 #5791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollie
force-pushed
the
gtk-debian-12
branch
3 times, most recently
from
ce852e4 to
377dbd7
Compare
`std.debug.assert(x)` _is not_ the same as `if (!x) unreachable` because the function call is not `inline`. Since it's not inline the Zig compiler will try to compile any code that might otherwise be unreachable. Also, added a CI test that compiles Ghostty in a Debian 12 container to ensure that regressions do not happen.
jcollie
force-pushed
the
gtk-debian-12
branch
from
377dbd7 to
0ce1342
Compare
mitchellh
reviewed
Feb 15, 2025
mitchellh
requested changes
Feb 15, 2025
mitchellh
reviewed
Feb 15, 2025
mitchellh
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std.debug.assert(x)is not the same asif (!x) unreachablebecause the function call is notinline. Since it's not inline the Zig compiler will try to compile any code that might otherwise be unreachable.Also, added a CI test that compiles Ghostty in a Debian 12 container to ensure that regressions do not happen.