Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk: add command palette #5681

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pluiedev
Copy link
Contributor

@pluiedev pluiedev commented Feb 11, 2025

GTK part of #5623

Depends on #5560 because writing custom GObject subclasses in Zig without a nice wrapper is like hitting your head with a sturdy piece of pickled mackerel

Currently still WIP: I think the only way for someone not to go insane with implementing complex widgets like this is to use either GTK Builder .ui files or to use Blueprint to generate UI files as a resource

@pluiedev pluiedev requested review from a team as code owners February 11, 2025 13:19
@pluiedev pluiedev marked this pull request as draft February 11, 2025 13:19
@pluiedev
Copy link
Contributor Author

Accidentally requested reviews from code owners: do not review this yet please!

Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly simple! I didn't heavily review the real meat of the action palette GTK stuff, just a cursory look. But I looked at the rest.

I think we should try to find a way to limit scope on this and split it up to make it a bit easier. We already have the gobject PR that's separate which is nice. I think I want to do the command palette core work in a separate PR that you can then try to rebase this on top of.

I also think introducing Blueprints (something I've always been supportive of!) as part of this makes it slightly more complicated too. Can we introduce blueprints for something simpler (say... the unsafe paste dialog or something) and get that in a separate PR so we can get all the machinery we need to work with blueprints within the project separate from a massive feature?

And finally, this should all of course wait for 1.2 😄

@pluiedev pluiedev added this to the 1.2.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants