Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default keybinds for move_tab #5009

Closed
wants to merge 1 commit into from

Conversation

aw1875
Copy link
Contributor

@aw1875 aw1875 commented Jan 13, 2025

Adds default keybinds for the move_tab action. I went with ctrl+shift+{left,right}_bracket since page_up/page_down is already bound to jump_to_prompt. Quick note, although the original issue is tagged for linux, this pr also handles macOS.

Closes #4998

@aw1875 aw1875 changed the title feat: add default keybinds for move_tab Add default keybinds for move_tab Jan 15, 2025
@jcollie jcollie added input Keyboard or mouse input os/linux os/macos labels Feb 15, 2025
@jcollie jcollie requested review from a team February 15, 2025 16:26
Copy link
Collaborator

@jcollie jcollie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM from the GTK side but I'd like to have a macOS reviewer take a look and see if these are appropriate for the macOS app.

@mitchellh
Copy link
Contributor

The spirit of the original issue was to add defaults that idiomatically match most apps. I think changing it to an alternate is not a good idea and should be left to users to customize. We may want to reassess our jump_to_prompt defaults instead so we can swap that out. Let's move the discussion back to the issue.

Thank you for the PR, though.

@mitchellh mitchellh closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
input Keyboard or mouse input os/linux os/macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GTK: Default keybinds for move_tab
3 participants