font(coretext): add config to adjust strength of font-thicken.
#4531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is achieved by rendering to an alpha-only context rather than a normal single-channel context, and adjusting the brightness at which coretext thinks it's drawing the glyph, which affects how it applies font smoothing (which is what `font-thicken` enables).
|
mitchellh
requested changes
Jan 4, 2025
| /// just the *lightest* thickening available. | ||
| /// | ||
| /// CoreText only. | ||
| thicken_strength: u8 = 255, |
There was a problem hiding this comment.
My only thought here is should we use a f32 here instead of a u8. It feels like this would be more user-friendly to configure for a range of "min" to "max". And it also looks like the Apple API is a CGFloat anyways.
There was a problem hiding this comment.
I considered it but it felt like false precision to me-- I'm not particularly bothered about it either way though so I'm fine with changing it to a float if you want.
There was a problem hiding this comment.
I can see the argument, but the argument types match and the difference between subtle changes should not be noticeable enough.
There was a problem hiding this comment.
I take it back, this causes hashing issues and I don't want to deal with it lol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is achieved by rendering to an alpha-only context rather than a normal single-channel context, and adjusting the brightness at which CoreText thinks it's drawing the glyph, which affects how it applies font smoothing (which is what
font-thickenenables).