Repository navigation
Don't steal focus on mouse events that are within 1 px - #3997
Merged
Merged
Conversation
mitchellh
force-pushed
the
gtk-fix-mouse-stealing
branch
from
January 2, 2025 21:46
8dd61b6 to
6a4842f
Compare
mitchellh
approved these changes
Jan 2, 2025
mitchellh
enabled auto-merge
January 2, 2025 21:47
christmic
pushed a commit
to christmic/Sylvander
that referenced
this pull request
Aug 12, 2026
…tually change. (#4973) Fixes #3345 Piggybacking on the logic introduced PR ghostty-org/ghostty#3997, this patch prevents mouse motion events with the same cursor position triggered by the window title updating from un-hiding the mouse even when `mouse-hide-while-typing` config item is true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3229
Gets the desired behavior for #3229, I'm unsure if there is a nicer way to omit the mouse motion events from the event controller
when the glarea is resized due to the splitting behavior. Thresholding to 1px is required because just checking for equality results
in the focus still being stolen sometimes. This is kinda of a hack so a nicer solution would be much appreciated!