Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Cmd + Shift + Plus should increase font size too #3956

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

curtbushko
Copy link
Collaborator

Addresses #3899.

It looks like Command + Shift + minus is a mac built-in keybinding while Command + Shit + plus is not. In my testing, the combos work (Command + minus, Command + Shift + minus, Command + plus, Command + Shift + plus)

From: Mac keyboard shortcuts

Shift–Command–Minus sign (-): Decrease the size of the selected item.

Shift–Command–Plus sign (+): Increase the size of the selected item. Command–Equal sign (=) performs the same function.```

(Note: I'm trying to find where iTerm2 does it in their code)

@mitchellh
Copy link
Contributor

(Note: I'm trying to find where iTerm2 does it in their code)

Beware that iTerm2 is GPL so if you find this, you can't copy the code.

@curtbushko
Copy link
Collaborator Author

Beware that iTerm2 is GPL so if you find this, you can't copy the code.

Thanks. I couldn't find the exact spot in their code anyway.

I think Config.zig is the place to put this as that was where you put the 'Natural text editing' keybinds the other day and it is kind of the same. I don't think we want it in Ghostty.Input.swift or in the swift code?

@mdznr
Copy link

mdznr commented Dec 30, 2024

The key equivalents for these menu items are just "+". AppKit does some menu item key equivalent localization by default.

@curtbushko curtbushko reopened this Dec 31, 2024
@peterjc
Copy link
Contributor

peterjc commented Jan 6, 2025

Will this handle command with the number pad add/plus (which works on the Apple Terminal, Firefox, etc - see issue for details)?

@curtbushko
Copy link
Collaborator Author

No, I don't think so because that is a different key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants