feat: add keybinding to reopen last closed tab #3822
Closed
+233
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your attempt at this and I'm sorry I didn't review this sooner. Your work here is quite good. I would have some review comments but I've decided to pursue this in a different direction: since there is so much apprt-specific state to involve in this feature (tab vs split, positions, etc.) I'm going to prefer to implement this purely at the apprt level rather than a core libghostty feature. As such, I'll close this. I'm sorry! |
|
No hards feelings, I had fun going deeper into ghostty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am NOT familiar with either Zig or Swift. This is a rough implementation and it might be wrong on many levels.
#1649