Bind ctrl+tab and ctrl+shift+tab by default #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches default behaviors on native apps for macOS and GTK so we should always bind it.
injust
reviewed
Oct 10, 2024
| alloc, | ||
| .{ .key = .{ .translated = .left }, .mods = .{ .ctrl = true, .shift = true } }, | ||
| .{ .previous_tab = {} }, | ||
| ); | ||
| try result.keybind.set.put( | ||
| alloc, | ||
| .{ .key = .{ .translated = .right }, .mods = .{ .ctrl = true, .shift = true } }, |
There was a problem hiding this comment.
Might be a stupid question, but why was the corresponding previous_tab removed, but this next_tab was kept in?
There was a problem hiding this comment.
This may have been a typo. Let me look into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches default behaviors on native apps for macOS and GTK so we should always bind it.