Action that writes both scrollback and active screen to file. #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, you can write the scrollback to a file, write the active screen to a file, but not both. This adds an action that writes both to a file.
|
ghostty/src/terminal/point.zig Lines 36 to 42 in 5f0371c |
|
Whoops! Thanks! |
MadLittleMods
added a commit
to MadLittleMods/fork-ghostty
that referenced
this pull request
Jan 22, 2025
mitchellh
added a commit
that referenced
this pull request
Jan 22, 2025
…creen_file`) (#5285) The current default keybinding on `Ctrl-Shift-J`/`Cmd-Shift-J` utilize [`write_scrollback_file`](https://ghostty.org/docs/config/keybind/reference#write_scrollback_file) which only captures text that's scrolled off-screen. This can be confusing, as I would expect it to capture everything on and off-screen. Per the docs, [`write_screen_file`](https://ghostty.org/docs/config/keybind/reference#write_screen_file) is the "Same as `write_scrollback_file` but writes the full screen contents" which is perfect to solve this problem and aligns exactly with the expected behavior. This change addresses the friction that people have reported in the discussions below and specifically coming from the [search scrollback feature discussion](#189), where `Ctrl-Shift-J`/`Cmd-Shift-J` is one of the interim decent workarounds but then you also have to figure out the extra intricacy to use `write_screen_file` instead of `write_scrollback_file`. Previous discussions: - #3652 - #3496 - #4911 - #4390 - #2363 (comment) - #189 (comment) - #2040 ### Workaround Before this PR is merged, you can achieve the same result by updating your Ghostty config: `.config/ghostty` ```sh # So we have more scrollback history (the size of the scrollback buffer in bytes) scrollback-limit = 100000000 # The default keybindings use `write_scrollback_file` but that only includes what is # offscreen. `write_screen_file` includes what's on screen and offscreen. keybind = ctrl+shift+j=write_screen_file:paste keybind = ctrl+shift+alt+j=write_screen_file:open ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you can write the scrollback to a file, write the active screen to a file, but not both. This adds an action that writes both to a file.