apprt/gtk: set mouse shape on GL area widget instead of overlay #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In b7699b9, mouse shape functionality was moved from the GL area widget to the overlay that was newly created for the URL target information that was included as part of #1928. This seems to have the side effect of causing the pointer shape to revert to the default shape (here, the basic arrow pointer) when dragging the mouse during selections. This moves it back to the GL area, which seems to correct this. It doesn't seem to need to be added to both - everything seems to function correctly when a link is moused over, and then selection is made down to the overlay area (not that this scenario is very likely, though).
|
Thanks. It wasn't clear to me what was correct... this is a good argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In b7699b9, mouse shape functionality was moved from the GL area widget to the overlay that was newly created for the URL target information that was included as part of #1928. This seems to have the side effect of causing the pointer shape to revert to the default shape (here, the basic arrow pointer) when dragging the mouse during selections.
This moves it back to the GL area, which seems to correct this. It doesn't seem to need to be added to both - everything seems to function correctly when a link is moused over, and then selection is made down to the overlay area (not that this scenario is very likely, though).
Current
2024-07-18.08-51-14.mp4
Fixed
2024-07-18.08-52-15.mp4