Repository navigation
Fix speedy high-resolution scrolling on Linux - #12483
Merged
Merged
Conversation
Contributor
|
Can you run zig fmt in here to fix that up? Other than that I'm fine giving this a shot. |
Enforcing an absolute minimum of 1 for scroll events causes differing scroll speeds between high-resolution and standard scroll wheels on Linux. Since this was added to handle MacOS's precision scrolling emulation, this patch alters the behaviour so that the absolute minimum is only enforced on MacOS. Fixes ghostty-org#11648.
rightaditya
force-pushed
the
fix-hires-scroll
branch
from
April 27, 2026 20:28
8e82641 to
5871a2d
Compare
Contributor
|
Thanks, also, I know zig fmt is easy to run, but I do a lot of PR review on mobile so... I can't actually do it lol. |
Contributor
Author
|
@mitchellh My bad. Done and rebased. |
Contributor
Author
|
And thanks, likewise. I don't have a Mac so I couldn't test it there, but the change seemed innocuous enough to at least be worth trying. |
Meo98
added a commit
to Meo98/meos-nixos-config
that referenced
this pull request
Sep 16, 2026
Der bisherige Text behandelte 'patch does not apply' als sauberes Verfalls- signal fuer den GANZEN Patch. Der ghostty-Fall zeigt, dass Hunks unabhaengig voneinander verfallen koennen: ghostty-hires-scroll.patch hat drei Hunks, Hunk 1 wurde upstream mit derselben Loesung behoben (ghostty-org/ghostty#12483, gemergt 2026-04-27), Hunk 2 und 3 sind in main unveraendert offen und ohne PR. Beim naechsten ghostty-Bump ueber v1.3.1 haette die Automatik zwei gueltige Fixes mit weggeraeumt. Neue Regel: hunkweise erneut anwenden; nur Hunks entfernen, die 'previously applied' melden; Kontext-Fehlschlaege sind ein echter Blocker (der Agent rebast nicht im Alleingang); Registereintrag nur loeschen wenn alles verfiel.
Meo98
added a commit
to Meo98/meos-nixos-config
that referenced
this pull request
Sep 16, 2026
…cht) Recherche zum ghostty-scroll-fix-Overlay: von den drei gepatchten Befunden hat upstream Befund 1 (Klemmung @max(yoff,1) auch auf Linux) selbst behoben - PR ghostty-org/ghostty#12483, gemergt 2026-04-27, mit derselben Loesung. v1.3.1 ist aber vom 2026-03-13 und seither neuester Tag, liegt also 862 Commits vor dem Fix -> unser Overlay braucht ihn weiterhin. Befund 2 (Sub-Zeilen-Rest wird verworfen, weil amount*cell_size wieder poff ergibt) und Befund 3 (x-Achse rundet Hi-Res-Ticks per @round auf null, ohne Akkumulator) sind in main unveraendert offen, ohne offenen PR. Beide als Patches gegen main (d4c88d8) vorbereitet, mit zig 0.16 ast-check geprueft inkl. Rot-Nachweis. NICHT eingereicht: ghostty hat ein Vouch-System, Meo98 steht nicht auf .github/VOUCHED.td, ungevouchte PRs werden automatisch geschlossen. Der Vouch-Request muss laut CONTRIBUTING.md in eigener Stimme geschrieben werden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforcing an absolute minimum of 1 for scroll events causes differing scroll speeds between high-resolution and standard scroll wheels on Linux. Since this was added to handle MacOS's precision scrolling emulation, this patch alters the behaviour so that the absolute minimum is only enforced on MacOS.
NB: This can't just be fixed by adjusting
mouse-scroll-multipliersince that affects all scroll events whether they're high-resolution or not. Reducingmouse-scroll-multiplierto handle high-res scroll events better makes scrolling unusably slow for regular scroll wheels connected to the same machine.Fixes #11648.