Repository navigation
core/gtk: add language config entry to override GUI localization - #10428
Conversation
|
I'm not 100% sure that this should be merged as it basically prevents us from localizing any error messages that originate from config parsing. Basically because we have to parse the config file to see if the language has been overridden before we can initialize the localization engine. Also not sure if the original LANG environment should be saved/restored. If we don't then any programs run within Ghostty also change languages. |
There was a problem hiding this comment.
I think it's worth to have this setting now as we don't really have parsing errors localized yet. For the long run we should probably use some sort of internal error enum that represents all failure cases instead of pushing raw strings into the config diagnostics
We should definitely preserve LANG for the child environment, since language is only supposed to override the interface language independent from the apps within.
2 participants
Fixes #10276