Repository navigation
Support native MacOS shortcuts to move to beginning and end of window - #10003
Merged
Merged
Conversation
…ve to end of document
Contributor
Author
|
the command history doesn't scroll back when I tested so I think we're OK as-is without preventing the event from being sent to Ghostty. For the page navigation when I do // Process MacOS native scroll events
switch selector {
case #selector(moveToBeginningOfDocument(_:)):
_ = surfaceModel.perform(action: "scroll_to_top")
case #selector(moveToEndOfDocument(_:)):
_ = surfaceModel.perform(action: "scroll_to_bottom")
case #selector(scrollPageUp(_:)):
_ = surfaceModel.perform(action: "scroll_page_up")
case #selector(scrollPageDown(_:)):
_ = surfaceModel.perform(action: "scroll_page_down")
default:
break
} |
Contributor
Author
|
This is part of #2526 |
bo2themax
requested changes
Dec 22, 2025
bo2themax
left a comment
Member
There was a problem hiding this comment.
Looks good to me, only a small suggestion
bo2themax
approved these changes
Dec 22, 2025
mitchellh
approved these changes
Dec 22, 2025
mitchellh
added a commit
that referenced
this pull request
Apr 12, 2026
Fix: #11989 Cause identified to: ab352b5 Original PR: #10003 Problem: I don't think it is OK to hard code the keybind like this at all. Ghostty's config is flexible enough to achieve this. Proposal: Revert the above commit via this PR. @yasuf @bo2themax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to scroll to the top or bottom of the window by using macOS native shortcuts, testing in video.
AI disclaimer: AI used to explore solutions, tested and edited solution proposed by Opus 4.5
testing_macos_3.mov