parse OSC1 and ignore it (set icon)

[vancluever]

Getting these in my log, even though the commands seem to be working:

xsession[321433]: warning(osc): invalid OSC command: 1;/etc/nixos

xsession[321433]: warning(osc): invalid OSC command: 8;;

Maybe some issue with parsing them that just needs to be fixed?

[mitchellh]

Our parser is just liberal in what it accepts. The log message should probably say “unrecognized OSC command” instead. This isn’t necessarily a bug unless these are OSC commands we want to support; there are many we explicitly do not want to support (because they’re either old/replaced or just functionality we’re not interested in).

[vancluever]

Yeah I'll check into it and see what's up there; when I thought they were supported I was misreading the enum in osc.zig but it doesn't look like the command IDs and commands line up? It's weird though too because it looks like the first one is a window title change and it came up fine.

But also we might want to change the log level here to debug then to prevent log spam?

[mitchellh]

But also we might want to change the log level here to debug then to prevent log spam?

Debug doesn't show up in release modes and it's been helpful for some people to see this to find OSC/CSI/etc. sequences that aren't supported for their workflow. If info is shown then we can switch to that. Or just change the wording to be a bit less bug-sounding.

[mitchellh]

It's weird though too because it looks like the first one is a window title change and it came up fine.

I'm unsure in this specific case but there are some programs that send multiple sequences to do the same thing because they're unsure which sequence a terminal may support. This may be one of those scenarios, too. Uncertain.

[mitchellh]

Looks like OSC 1 is "set icon": https://invisible-island.net/xterm/ctlseqs/ctlseqs.html That's not something I'm interested in supported but we should parse it. OSC 8 is URL related and covered by #29. We should not parse that yet and should show a log message until #29 is implemented.

[vancluever]

Debug doesn't show up in release modes and it's been helpful for some people to see this to find OSC/CSI/etc. sequences that aren't supported for their workflow. If info is shown then we can switch to that. Or just change the wording to be a bit less bug-sounding.

👍 1 was showing much much more than 8 anyway. Now I'm wondering what icons it was trying to set. 😄