Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: Quick Terminal - Cmd-T should show error, not create new window/tab #5939

Closed
mitchellh opened this issue Feb 22, 2025 · 0 comments · Fixed by #5955
Closed

macOS: Quick Terminal - Cmd-T should show error, not create new window/tab #5939

mitchellh opened this issue Feb 22, 2025 · 0 comments · Fixed by #5955
Labels
gui GUI or app issue regardless of platform (i.e. Swift, GTK) os/macos
Milestone
1.2.0

Comments

@mitchellh
Copy link
Contributor

Discussed in #5642

Originally posted by edrozenberg February 8, 2025
While focused on Quick Terminal:

  • Menu File -> New Tab shows error: "Cannot Create New Tab" ✅
  • Keyboard shortcut "Cmd+T": creates a new window the same size and location as the Quick Terminal, or a new tab in an existing window. ❌

Suggestion: for consistency, when focused on Quick Terminal, both the menu action AND keyboard shortcut should have the same effect i.e. show the error dialog.
@mitchellh mitchellh added gui GUI or app issue regardless of platform (i.e. Swift, GTK) os/macos labels Feb 22, 2025
McNight added a commit to McNight/ghostty that referenced this issue Feb 23, 2025
@McNight
fix(macos): prevent performing newTab shortcut on QuickTerminalWindow g…
aa4aaa2 
…hostty-org#5939
@McNight McNight mentioned this issue Feb 23, 2025
Merged
McNight added a commit to McNight/ghostty that referenced this issue Feb 24, 2025
@McNight
fix(macos): address MR feedback ghostty-org#5939
1254c6b
McNight added a commit to McNight/ghostty that referenced this issue Feb 24, 2025
@McNight
fix(macos): make showNoNewTabAlert method private ghostty-org#5939
b4349d3
mitchellh added a commit that referenced this issue Feb 24, 2025
@mitchellh
fix(macos): prevent performing newTab shortcut on QuickTerminalWindow… (
92340f8 
#5955)

Fixes #5939
@github-actions github-actions bot added this to the 1.2.0 milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gui GUI or app issue regardless of platform (i.e. Swift, GTK) os/macos
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

fix(macos): prevent performing newTab shortcut on QuickTerminalWindow… McNight/ghostty
1 participant
@mitchellh