macOS: Regression of menubar "blinks" when executing keyboard shortcuts

[taylrfnt]

Summary

When MacOS applications have a keyboard shortcut executed the typical behavior is that if the shortcut corresponds to an item in the menu, the menubar will "blink" in sync with the shortcut keypress(es). This also extends to the specific menu item, if the menu collection containing that item is visible, it also "blinks."

Here's a quick example with FireFox, since there doesn't appear to be much standard Apple nomenclature for this behavior that I can find:
https://github.com/user-attachments/assets/f9b9b2b3-49bf-46cd-bfa9-1b5d2e50cdc8

Regression Bisect

Since #4590 (originating from #3187), the menu will no longer "blink" for any shortcuts that are in the menu bar except for two items:

• Window → Minimize (super+m)
• Window → Show All Tabs (super+shift+t)

Commit 32c4a9d appears to be the offending commit, per the results of my bisecting below:

commit 7e1260c9 (built from source)

All menu items blink as expected:

32c4a9d (built from source)

Starting with 32c4a9d, only the two aforementioned shortcuts result in an menubar blink when the menubar is not expanded/visible. Note that the shortcuts will only blink when their corresponding option is displayed onscreen:

[mitchellh]

This was an explicit decision in order to support overridable system bindings and others. If someone wants to fix this then I'd accept it but I'm not going to consider this a bug at this time.