-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools scala3 zio r17 #1248
Tools scala3 zio r17 #1248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a tiny comment!
@ghostdogpr @pmeheut Shouldn't we write tests to validate that it's working and continue to work over time? Maybe a new project using Scala3 in the scripted tests of the codegen module? |
I can do this if you are in no hurry. Current tests in codegen are Scala 2.12 only I think. Should I make them cross-version or do something specific for Scala 3? |
@pmeheut The best would be to create a third test project, not modifying the two others because they are testing their own stuff. Sadly, I think we'll be limited by sbt. I remember being forced to use Scala 2.12 instead of 2.13 in the test project because of sbt which is using Scala 2.12 but maybe I was wrong. Maybe I could have used Scala 2.13 which means that you maybe can write this third test project using Scala3. Can you please give it a try, maybe? |
I'll give it a try and let you know. |
@guizmaii: the test project, i.e compiletime-codegen compiles indeed with 2.13. The plugin in 2.12 is called, generates the code that is then compiled and run under the current scalaVersion. So it should compile with Scala 3 too because it is close to my own project but I get strange error messages. I'll try and fix this and then, we should have a cross-compiling for 2.12, 2.13 and 3 test. |
This is to avoid name-clashes with types from the graphql schema, i.e., if a type is called Vector. Example: enum ImageType { Raster Vector }
* update tapir to 1.0.1 * update examples
* Update scala-library to 2.12.16 * Update config.yml Co-authored-by: Pierre Ricadat <[email protected]>
* Update scala3-library, ... to 3.1.3 * Update config.yml Co-authored-by: Pierre Ricadat <[email protected]>
Closing old PRs, but feel free to reopen it targeting the |
Attempted solution to: #1239
Used scalameta/scalafmt#3035 (comment) suggestion to load scalafmt dynamically, allowing to generate a Scala 2.12/2.13 & 3 of caliban-tools and using the sbt-codegen plugin in Scala 3.