Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I started to add code for test build to test the iso boot. #199

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Sep 8, 2024

Summary by Sourcery

Add a test build option to the build script for testing ISO boot with FreeBSD packages and improve variable naming for clarity.

New Features:

  • Introduce a new test build option in the build script to test ISO boot with FreeBSD OS packages.

Enhancements:

  • Correct variable naming inconsistencies in the build script for better readability and maintainability.

@ericbsd ericbsd requested review from a team as code owners September 8, 2024 22:36
Copy link
Contributor

sourcery-ai bot commented Sep 8, 2024

Reviewer's Guide by Sourcery

This pull request adds support for a test build option to test ISO boot functionality. It modifies the build script to accommodate a new test mode, updates supported FreeBSD versions, and improves the help function output.

File-Level Changes

Change Details Files
Added support for a test build option
  • Introduced a new '-t' flag for test builds
  • Created a new 'test' desktop option
  • Added conditional logic to handle test builds differently
  • Modified package selection for test builds
  • Changed version naming for test builds
build.sh
Updated supported FreeBSD versions
  • Removed '13.2-STABLE', '14.0-STABLE', and '14.1-PRERELEASE'
  • Added '13.3-STABLE'
build.sh
Improved help function output
  • Added newline characters to improve readability
  • Included information about the new test option
build.sh
Refactored variable names for consistency
  • Changed 'PKGCONG' to 'PKG_CONF'
  • Renamed 'cdroot' to 'cd_root'
  • Updated 'liveuser' to 'live_user'
build.sh
Modified build process for test mode
  • Skipped certain steps (e.g., packages_software, desktop_config) for test builds
  • Added conditional logic to use different base package lists for test builds
build.sh

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider refactoring to centralize test-specific logic for better maintainability.
  • Standardize naming conventions throughout the script (e.g., choose either snake_case or camelCase consistently).
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

build.sh Show resolved Hide resolved
@ericbsd ericbsd merged commit 94b7718 into master Sep 8, 2024
1 check passed
@ericbsd ericbsd deleted the test-build branch September 8, 2024 22:41
@ericbsd ericbsd self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant