fix(styling): Grid Menu & Column Picker overflow in Firefox #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove overflow-x for all browsers, we don't need a scroll to show at any point in time for the x coordinate - Firefox has issues when overflow (auto) shows the scroll, it shows up over the text while Chrome seems to add necessary padding to avoid that problem, so we can add a fixed right padding for Firefox only, we don't want to make it too wide because that would look funny
ghiscoding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. (before) in Firefox (column name is cut off and extra scrollback shows up in x axis)
2. (after) with extra padding on the right in Firefox only (x axis scrollbar is gone)