fix(addons): onGroupChanged callback should be executed with Draggable #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- after rewriting all SlickGrid plugins into standalone Slickgrid-Universal extensions, it seems that the `onGroupChanged` function was forgotten and the new code was never executing it when it was defined as a function callback by the user, this PR fixes that
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 239 239
Lines 16362 16366 +4
Branches 5776 5777 +1
=========================================
+ Hits 16362 16366 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Dec 1, 2022
- add E2E tests for the real fix that was applied in Slickgrid-Universal [PR](ghiscoding/slickgrid-universal#826)
ghiscoding
added a commit
to ghiscoding/Angular-Slickgrid
that referenced
this pull request
Dec 1, 2022
- add E2E tests for the real fix that was applied in Slickgrid-Universal [PR](ghiscoding/slickgrid-universal#826)
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Dec 2, 2022
#903) - add E2E tests for the real fix that was applied in Slickgrid-Universal [PR](ghiscoding/slickgrid-universal#826)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onGroupChangedfunction callback was forgotten and the new code was never executing it when it was defined as a function callback by the user, this PR fixes that. Note that theonGroupChangedcan be both a function callback (defined by the user in its grid option) and a Slick Event that has notify/subscribe