feat(filters): add grid option skipCompoundOperatorFilterWithNullInput
#794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Should we skip filtering when the Operator is changed before the Compound Filter input. - For example, with a CompoundDate Filter it's probably better to wait until we have a date filled before filtering even if we start with the operator. - Defaults to True only for the Compound Date Filter (all other compound filters will still filter even when operator is first changed).
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 236 236
Lines 16434 16450 +16
Branches 5538 5548 +10
=========================================
+ Hits 16434 16450 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skipCompoundOperatorFilterWithNullInputto skip filtering when the Operator is changed before the Compound Filter input value.